Support new attribute shorthand #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkatychev
commented
Aug 27, 2024
| @@ -551,7 +551,7 @@ recipes containing attributes with arguments | |||
| ================================================================================ | |||
|
|
|||
|
|
|||
| [group("foo"), group("echo")] | |||
| [group("foo"), group: "echo"] | |||
There was a problem hiding this comment.
the s-expr should not change at all since this is an alternative form of the same statement
|
Getting an npm error on |
|
Hey sorry I totally missed this. Could you turn this into separate PRs, one that does the grammar updates (for the shorthand) and a separate one doing the support/CI/gitignore/etc updates? The grammar updates is small and looks great to me, everything else needs some more discussion. |
|
No worries, should get to this by EOW |
|
@tgross35 this should be ready to review once more |
|
https://github.com/IndianBoy42/tree-sitter-just/actions/runs/11768782768/job/32778994256?pr=173 should generated code be omitted from formatting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for new attribute shorthand:
https://github.com/casey/just/blob/fa5770e71aa93402068ebc9e179e493fc94f8532/tests/attributes.rs#L202-L205